-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to store the best physical (i.e. unnormalised) model #2
Merged
htoftevaag
merged 16 commits into
main
from
Find-a-way-to-store-the-best-physical-(i.e.-unnormalised)-model
Aug 5, 2021
Merged
Find a way to store the best physical (i.e. unnormalised) model #2
htoftevaag
merged 16 commits into
main
from
Find-a-way-to-store-the-best-physical-(i.e.-unnormalised)-model
Aug 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some trcwa stuff and constants
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
…Initial-structure
- Added test for trcwa - Added some logging and asserts - Renamed constants due to import behavior - Some minor fixes - Finalized backend removal from trcwa
- Cleaned up import mess - Added test for frequency conversion - Training NB WIP - Started adding a function to validate cfgs
- Reworked plots to work with models - Added missign cfg params and checks for them - Made sigmoid def - Small fixes - Relocated validate config
- Added some logging
This was referenced Aug 5, 2021
htoftevaag
requested changes
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Pablo Typóz
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
htoftevaag
approved these changes
Aug 5, 2021
htoftevaag
deleted the
Find-a-way-to-store-the-best-physical-(i.e.-unnormalised)-model
branch
August 5, 2021 15:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #1 first.
Validated it in debug