CN-147 refactor work #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew-viles
force-pushed
the
CN-147-refactor-work
branch
5 times, most recently
from
0000c1d
to
ef4b301
Compare
Previously there were calls to viper.GetSomething all over the code. This was prone to error if a value changed so now the code has been refactored to process any viper inputs. Flags will always override the viper config file and any fields not supplied will use the defaults where applicable. Added checksum validation for the Trivy cli download Removed duplicate Trivy report structs and generally moved some bits around to begin work for allowing other clouds to be used. There is still work to be done to allow other clouds though as it's still generally OpenStack focussed. Added new docs/readme & changelog Fixes #32 & Fixes #34
drew-viles
force-pushed
the
CN-147-refactor-work
branch
from
ef4b301
to
2fbe76b
Compare
yankcrime
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked code to remove direct calls to
viper.GetXXXXPreviously there were calls to viper.GetSomething all over the code. This was prone to error if a value changed so now the code has been refactored to process any viper inputs.
Flags will always override the viper config file and any fields not supplied will use the defaults where applicable.
Also:
Note
All testing has been completed from
buildingan image throughscan,signandpublishand all were functional. I need to look at how to automate this at some point in the pipeline so we can have the confidence in releases ;-)