C2s/merge master #3790
C2s/merge master #3790
Conversation
Motivation: This is the only mongoose_client_api_* module, which used mongoose_commands, and we are moving away from this solution towards a GraphQL-oriented one. Thus, the (soon to be deprecated) REST API needs to be simplified and use the *_api modules directly. Main changes: - Added direct calls to mod_roster_api to mongoose_client_api_contacts - Added type specs for request-handling functions - Disabled client contacts API in mod_commands
mongoose_api_client was replaced by mongoose_client_api, but it was still possible to configure both, confusing the user. The only functionality lost by this change is the 'cahnge_password' command, which was undocumented anyway. We can readd it as 'mongoose_client_api_accounts' if needed.
Do not use mongoose_commands in the Client REST API
Added tests for domain admin in graphql_roster_SUITE. The tests are similar to those for a global admin, but they also check for permissions.
Domain admin tests in roster suite
There is two new interfaces: one simply broadcasts a new value given a key to all workers. The other, broadcasts new important data that should be aggregated to all available keys. This is useful if we need to modify whatever tasks are pending.
Implement broadcasts in async pools
Extend aggregator requests and fix stall-after-error bug
This module will delegate Admin REST API calls to the handler modules, just like mongoose_client_api is doing for client API requests.
Also: fix types in mod_roster_api
Also: fix types in mongoose_stanza_api Marked missing error handling as TO DO - it will be done in a separate task.
Also: fix types and whitespace in mod_inbox_api
Also: fix types in mod_muc_api
Also: fix types and typos (sic!) in MUC Light modules
- Update expected messages - Actually test message errors for MUC (invites were tested instead) - Remove tests for listing commands and adding mongoose_commands Command listing will be possible only with GraphQL, and mongoose_commands will be removed in a follow-up PR. Also: remove test repeat
Also: reorganize tests for easier management
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/merge_master
branch
from
c9e8cb0 to
818f120
Compare
Refactored hook handler in mod_global_distrib_disco module
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
They are documented, and the user could define them with different values if necessary.
There is an issue with the overriding logic in relx: included vars override previously defined ones, but there is no simple way of overriding the included vars other than including another file. This way making the dev releases resulted in incorrect vars. Big tests succeeded because they had their own overriding logic. It seems that we could do without overriding entirely, and this change shows that the resulting files are actually more straightforward.
Don't override included overlay vars
Graphql use annotation
NelsonVides
force-pushed
the
c2s/merge_master
branch
from
cdb15bf to
01bc480
Compare
|
small_tests_24 / small_tests / 01bc480 small_tests_25 / small_tests / 01bc480 ldap_mnesia_24 / ldap_mnesia / 01bc480 ldap_mnesia_25 / ldap_mnesia / 01bc480 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 01bc480 internal_mnesia_25 / internal_mnesia / 01bc480 pgsql_mnesia_24 / pgsql_mnesia / 01bc480 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 01bc480 riak_mnesia_24 / riak_mnesia / 01bc480 pgsql_mnesia_25 / pgsql_mnesia / 01bc480 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 01bc480 mysql_redis_25 / mysql_redis / 01bc480 mssql_mnesia_25 / odbc_mssql_mnesia / 01bc480 |
No description provided.