Skip to content

Bug: 17.16.0 was an accidental breaking change due to the transitive typescript peerDependency #415

Closed
@Windvis

Description

@Windvis

Environment

Node version: 18
npm version: N/A
ESLint version: N/A
eslint-plugin-n version: 17.16.*
Operating System: Ubuntu

What rule do you want to report?

N/A

Link to Minimal Reproducible Example

https://github.com/ember-cli/ember-cli/actions/runs/13622746104/job/38074935446#step:4:97

What did you expect to happen?

No errors when running eslint in a non-ts project.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

It seems that this pr: #392 added a new dependency on ts-declaration-location which has a peerDependency on typescript. This results in eslint throwing errors when running in a project that doesn't use typescript.

This is causing some of the CI jobs to fail in the ember-cli project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions