Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 17.16.0 was an accidental breaking change due to the transitive typescript peerDependency #415

Closed
1 task
Windvis opened this issue Mar 3, 2025 · 3 comments
Labels

Comments

@Windvis
Copy link

Windvis commented Mar 3, 2025

Environment

Node version: 18
npm version: N/A
ESLint version: N/A
eslint-plugin-n version: 17.16.*
Operating System: Ubuntu

What rule do you want to report?

N/A

Link to Minimal Reproducible Example

https://github.com/ember-cli/ember-cli/actions/runs/13622746104/job/38074935446#step:4:97

What did you expect to happen?

No errors when running eslint in a non-ts project.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

It seems that this pr: #392 added a new dependency on ts-declaration-location which has a peerDependency on typescript. This results in eslint throwing errors when running in a project that doesn't use typescript.

This is causing some of the CI jobs to fail in the ember-cli project.

@voxpelli
Copy link
Member

voxpelli commented Mar 4, 2025

That's bad,I guess the only option is to revert for now and to add tests to ensure this doesn't happen again

I think I added the capability to test this in installed-check, we could see if that help

@scagood
Copy link

scagood commented Mar 4, 2025

That's bad,I guess the only option is to revert for now and to add tests to ensure this doesn't happen again

Agreed #416 is the revert

@Windvis
Copy link
Author

Windvis commented Mar 6, 2025

Closing since it was reverted in 17.16.2. Thanks for the quick response!

@Windvis Windvis closed this as completed Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants