-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ignoring sync methods from certain locations #392
feat: add support for ignoring sync methods from certain locations #392
Conversation
c399441
to
1781930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! Sorry for the delay in reviewing 🙈
The code looks nice, and everything looks well thought through. I have a couple of minor questions :)
Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
04bf3ba
to
9d9e60e
Compare
Edit: I've updated the logic for this. It's much simpler now and actually works. |
a5454cb
to
e554e55
Compare
tests pass on my machine but not in CI... |
This comment was marked as outdated.
This comment was marked as outdated.
Failing tests issue resolved - I didn't commit a few files (the ones in the fixture node_modules dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach and the code -- Thank you for the tests too!
Im going to leave this for a day or two to see if anyone else from @eslint-community/eslint-plugin-node want to review. But thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It looks like the CI has been failing since this PR was merged making the latest release fail |
It should have nothing to do with this change - even though I switched to the previous commit it still fails. let's discuss it in #409 |
Fixes #391
Adds the ability to ignore entire packages, or just a subset of functions from them along with other things.
This also resolves the issue of name clashes.
Example:
This follows ts eslint's TypeOrValueSpecifier.