Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add TypeScript support section #159

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented May 17, 2024

This PR adds the explanation about TypeScript support to README.md so that users can notice type definitions are available by the external pacakge.

Fix #157

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @nzakas to review before merging.

@rhysd
Copy link
Contributor Author

rhysd commented May 17, 2024

Note: CI job failed but it seems not related to change in this PR:

Loading preset package
Error: Preset "conventional-changelog-angular" does not exist.

@aladdin-add
Copy link
Contributor

yes, it's unrelated to the change.

Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit dcf97a7 into eslint-community:main May 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no type definitions for eslint flat config
3 participants