fix: improve HTML id/name regex for unquoted values and spaces#480
Merged
nzakas merged 1 commit intoeslint:mainfrom Jul 30, 2025
Merged
fix: improve HTML id/name regex for unquoted values and spaces#480nzakas merged 1 commit intoeslint:mainfrom
nzakas merged 1 commit intoeslint:mainfrom
Conversation
Contributor
|
Hey @TKDev7, before raising a PR, please create an issue first and wait for it to be accepted, so the team can align on the change and ensure the effort is well-directed. |
Contributor
Author
|
@snitin315 This is 100% a bug though. Do we create an issue first for these as well? |
Contributor
|
Yes, please create an issue first for any change, be it refactoring code, tests, docs, or a bug. |
Contributor
Author
|
Alright, I created one: #481 |
1 task
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I tried to use ultrahtml here but it has a bug. |
lumirlumir
approved these changes
Jul 24, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
Thanks for trying out ultrahtml. It needs a bit more investigation, so it's fine not to use it here for now.
LGTM, Would like another review before merging.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
To improve the detection of HTML id and name attributes in the
no-missing-link-fragmentsrule, ensuring that unquoted attribute values and spaces around the equals sign are correctly handled. This fixes false negatives/positives for valid anchor references in Markdown files.What changes did you make? (Give an overview)
<h1 id=bookmark>)<h2 id = bookmark-2>)Related Issues
Fixes #481
Is there anything you'd like reviewers to focus on?