refactor: correct no-reversed-media-syntax selectors#508
Conversation
|
Please create an issue before working on a fix so the team can align on the direction we want to take. As far as I know, @snitin315 has been asking you to follow our contributing guidelines here: #500 (review), #480 (comment), eslint/css#171 (comment), eslint/rewrite#233 (comment) I hope you'll follow our guidance. Edit: Also, if you plan to submit a fix directly, please use our bug issue template so we can more clearly identify the problem. I agree that this change could save some calculations, but I don't think it's a bug fix. Do you have any examples where this change is actually fixing false negatives or positives? Since the |
|
@lumirlumir Could you please clarify why this PR doesn’t qualify for the exception criteria? I tried to describe the issue clearly in the PR.
|
|
I think there's been some confusion lately over what does and doesn't require an issue. Bug fixes typically do not require an issue, but we do want the PR description to contain the same information as a bug report. So we're looking for a clear description of the problem, reproduction steps, example code, current behavior, and expected behavior. @TKDev7 if you can please update the description of the PR with this info, it would be very helpful. |
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, Would like another review before merging.
I'm changing the type of the PR title to refactor, since this is not a user-facing bug fix.
Prerequisites checklist
Example Code
Current Behavior
The selector syntax:
"heading html,inlineCode"is interpreted as:inlineCodenode anywhere in the documentWhile in practice this behaves as intended since
inlineCodecan only appear inside headings, paragraphs, or table cells, the syntax can be misread and is less explicit about its scoping.Expected Behavior
Selectors should clearly indicate that both
htmlandinlineCodeare matched only when nested within the relevant container node.What is the purpose of this pull request?
This PR fixes selector patterns to make their scope explicit and easier to read, replacing comma-separated selectors with
:matches()expressions.What changes did you make? (Give an overview)
"heading html,inlineCode"with :matches() expressions like"heading :matches(html, inlineCode)"Related Issues
Is there anything you'd like reviewers to focus on?