Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Add async/await support #129

Merged
merged 2 commits into from
Jan 4, 2017
Merged

Add async/await support #129

merged 2 commits into from
Jan 4, 2017

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Dec 18, 2016

I split this into two commits, because the second one is a rather mechanical addition of async: false to every single fixture containing a function (=almost all)

(fixes #119)

@eslintbot
Copy link

Thanks for the pull request, @flying-sheep! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslintbot
Copy link

LGTM

@flying-sheep
Copy link
Contributor Author

travis failure is due to #128

please fix travis or ensure manually that my tests run with TypeScript 2.0.10.

I beg you to merge this quickly so that I don’t have to adapt this to every unit test change merged before this.

@JamesHenry
Copy link
Member

I'm sure you can appreciate that the week before Christmas is exceptionally busy. Rest assured, I will be looking at this as soon as possible.

@flying-sheep
Copy link
Contributor Author

oh, of course! i don’t want to pressure you, is just wanted to ask you to consider fast-tracking this to get in before other PRs or changes

@JamesHenry
Copy link
Member

Thanks a lot for your patience on this, @flying-sheep! Once #131 gets merged you can rebase this

@JamesHenry
Copy link
Member

It's in! Please rebase the PR and we'll see where we're at 😄

@eslintbot
Copy link

LGTM

@flying-sheep
Copy link
Contributor Author

@JamesHenry done!

@JamesHenry
Copy link
Member

Thanks a lot, glad to see that addressed the failing tests!

Given that they both touch a lot of existing assertions around functions, I think it might be sensible to hold off on this PR just until this other one gets resolved: #124

Shouldn't take too much longer!

@JamesHenry
Copy link
Member

The other PR ended up being more isolated than it first appeared.

This LGTM, thanks a lot!

@JamesHenry JamesHenry merged commit 60843ad into eslint:master Jan 4, 2017
@flying-sheep flying-sheep deleted the async branch January 9, 2017 10:27
@flying-sheep
Copy link
Contributor Author

great, thanks! sorry again for sounding pushy, y’all’re doing a great job here!

soda0289 pushed a commit to soda0289/typescript-eslint-parser that referenced this pull request Jan 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Async Await to ESTree format
3 participants