-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-b and --fq-rate flags should be mutually exclusive #1597
Comments
There could be a use case for using both rate limits with --bidir, since --fq-rate doesn't apply to the server (yet). It might be better to print a warning instead, like when a large, but valid UDP length is set in iperf. |
FYI I am currently using both for the exact reason @WBINVD mentioned. I am running a bidirectional test where I need to constrain the bandwidth in both directions. The ideal would be if --fq-rate worked on both client and server, since it has lower CPU overhead, but as a workaround I specify both, with a slightly higher value for --bitrate. e.g.
With this approach, CPU usage stays low on the client because --fq-rate kicks in before --bitrate, and --bitrate works on the server side. cc @bmah888 please don't merge the PR until --fq-rate is supported on the server. |
See #1632 |
Going to close this issue for now because, while the behavior from specifying both -b and --fq-rate can create confusion, it’s not outright harmful. We can re-open it later if there’s a more compelling reason. |
I think it does not make sense to give both -b and --fq-rate flags for iperf3.
iperf3 should give an error in that case.
The text was updated successfully, but these errors were encountered: