Disallow specifying both -b and --fq-rate together. #1602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're going to hold off on merging this, pending investigation of reports of the combination of |
|
See #1632 |
|
Going to close this PR for now because, while the behavior from specifying both -b and --fq-rate can create confusion, it’s not outright harmful. We can re-open it later if there’s a more compelling reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1597.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:masterIssues fixed (if any): -b and --fq-rate flags should be mutually exclusive #1597
Brief description of code changes (suitable for use as a commit message):
Don't allow both
--b/--bitrateand--fq-rateto be specified in the same invocation of iperf3.