-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UART type erasure #2381
Conversation
40da306
to
5c4c0f3
Compare
1ce8234
to
e3aad0c
Compare
|
f67b298
to
0657965
Compare
fn interrupt() -> Interrupt; | ||
fn interrupt(&self) -> Interrupt; | ||
|
||
#[doc(hidden)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really related but ....
I wonder if we should doc-hide all those Instance
/RegisterAccess
traits 🤔
We do for some peripherals (e.g. I2c
) but for most we don't - however it's something that would be just confusing to users in best case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run, I want to split out the RegisterBlock/signal part of the trait, and make it public. The rest (i.e. the actual driver implementations) will I think remain private. I'm hiding these things mostly as an "under construction" sign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - feel free to think about doc-hiding the Instance trait or merge as is
Are we fine with me disabling LTO in the test suite? |
What would be the alternative? |
Figuring out what's wrong, fixing the compiler and holding off the PR until the fix is released 😅 |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra: