-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add esp32c6 #123
add esp32c6 #123
Conversation
Hi @seanaye! Thanks for your contribution! We would also need some logic, as the new targets are not supported in some ESP-IDF versions, see https://github.com/espressif/esp-idf#esp-idf-release-and-soc-compatibility. |
Do you have a suggestion for how you're thinking of this? I've never edited a cargo-generate template before, but from my struggles it seems that this isn't an easy thing to do. |
I have this, but it's not pretty, and will grow "infinitely" as more boards are released which need new SDKs.
|
Also missing: {
"arch": "riscv32",
"cpu": "generic-rv32",
"data-layout": "e-m:e-p:32:32-i64:64-n32-S128",
"eh-frame-header": false,
"emit-debug-gdb-scripts": false,
"env": "newlib",
"features": "+m,+a,+c",
"is-builtin": false,
"linker": "riscv32-esp-elf-gcc",
"llvm-target": "riscv32",
"max-atomic-width": 64,
"os": "espidf",
"panic-strategy": "abort",
"relocation-model": "static",
"target-family": [
"unix"
],
"target-pointer-width": "32",
"vendor": "espressif"
} invoked with |
Support for riscv32imac-esp-espidf was merged a couple of days ago: rust-lang/rust#111369 I have modified a project generated by this template locally, and I can confirm that the Hello World example works with a C6 board given you're using a nightly rust build. So now, ideally, the template should be made to work, and documentation updated. |
🤩 nice, i missed that merge |
@@ -23,6 +23,24 @@ let targets = #{ | |||
gcc_target: "riscv32-esp-elf", | |||
wokwi_board: "board-esp32-c3-devkitm-1", | |||
}, | |||
esp32c6: #{ | |||
arch: "riscv", | |||
rust_target: "riscv32imc-esp-espidf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be riscv32imac-esp-espidf
(imAc) for esp32c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #124
I have put my proposal in #125 |
Adds the options for the esp32 c6 dev board in the cargo generate toml