Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow supported ESP-IDF targets #125

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Only allow supported ESP-IDF targets #125

merged 1 commit into from
Jun 12, 2023

Conversation

sredman
Copy link
Contributor

@sredman sredman commented Jun 11, 2023

Per discussion on #123

Only allow the user to select ESP-IDF targets which support the selected MCU.

This should work without #124, even though some of the MCU targets don't exist until that is merged.

@sredman
Copy link
Contributor Author

sredman commented Jun 11, 2023

This was referenced Jun 11, 2023
@sredman
Copy link
Contributor Author

sredman commented Jun 11, 2023

Tested end-to-end on my esp32c6 devboard: I can create a fresh project, build, flash, and see "Hello World". I have to edit the targets in the .cargo/config.toml, fix proposed in #124.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@SergioGasquez SergioGasquez merged commit c8080ab into esp-rs:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants