-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardware SPI BREAKING: unswap mode 2 and 3 for portability #5948
Conversation
use SPI.restoreEsp8266LegacyMode2And3() for former behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest marking the method as deprecated right away.
Per #2416 (comment), I think it would make things not consistent. Marking it deprecated is a way to tell user to change source code. If we want that, I'd just remove this new call (see the number of votes in the comment just before mine). Keeping it as it is will help esp8266-only trans-core-version projects to live until they are able to make it without older cores. To summarize:
edit: removed |
Thanks! 👍 |
Hmmm... I might be missing something, but I do not find "SPI.restoreEsp8266LegacyMode2And3() " |
Great, everything works as expected for 2.5.1, see olikraus/u8g2#53 |
use
SPI.restoreEsp8266LegacyMode2And3()
for former behaviourfix #2416
close #2418
This snippet can be used to manage this breaking change and portability.