ESP8266 SPI modes were unswapped, need to fix SPI code

[SaintGimp]

Previously the SPI implementation for the ESP8266 had mode 2 and 3 swapped. The ATM90E26 code checks if it's compiling for ESP8266 and specifies mode 2 (which is really mode 3) in that case. However, the mode swap has been fixed in the ESP8266 board files, so the ATM90E26 code should now just specify mode 3 in all cases. The code as it is right now won't run on ESP8266 until it's fixed.

[whatnick]

Thanks so much for the heads up. Would it be possible to create an ESP-Arduino version check + mode selection patch to keep it running for those who have not upgraded the board support yet ? I am working on this project again. I will try to implement it. If you have time I would love a patch.

…

On Thu, Jan 2, 2020, 16:23 Eric Lee ***@***.***> wrote: Previously the SPI implementation for the ESP8266 had mode 2 and 3 swapped <esp8266/Arduino#2416>. The ATM90E26 code checks if it's compiling for ESP8266 and specifies mode 2 (which is really mode 3) in that case. However, the mode swap has been fixed in the ESP8266 board files <esp8266/Arduino#5948>, so the ATM90E26 code should now just specify mode 3 in all cases. The code as it is right now won't run on ESP8266 until it's fixed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20?email_source=notifications&email_token=AADX7BFLBA2TS5VJZGENC2LQ3V25ZA5CNFSM4KB6VPNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDTU5RA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADX7BFHITOSPCZMWILM6X3Q3V25ZANCNFSM4KB6VPNA> .