-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC 10.3 Bugfix 1 - Constant literal address fix #8393
Conversation
Fixes esp8266#8314 and other hard-to-track bugs. GCC 10.3 had an issue with addressing constant literals which would result in crazy offsets being used and random crashes in production. Update with an upstream GCC 11 bugfix.
@mcspr , I see your PIO package for this (mcspr/toolchain-xtensa @ ~5.100300.211127). Would it be possible to upload the binaries for 'darwin_arm64'? |
@mcspr , So it's the exact same files from the release packaged for PIO? Wonder how I tell my M1 MAC to just use the x64 intel version and virtualize it with Rosetta?? Do you know why the default pckage works fine on the M1 MAC but this toolchain does not and instead errors out on could not find darwin_arm64? |
Hmm... The registry payload returns x86_64 version for both, I suppose package.json was modified to include it {
"checksum": {"sha256": "0a40e1cc5f6f9cedd85d3d4dac548bfb5535c015c40cb10a7755f7dbd3f1db4c"},
"download_url": "https://dl.registry.platformio.org/download/platformio/tool/toolchain-xtensa/2.100300.210717/toolchain-xtensa-darwin_x86_64-2.100300.210717.tar.gz",
"name": "toolchain-xtensa-darwin_x86_64-2.100300.210717.tar.gz",
"size": 75089523,
"system": ["darwin_x86_64", "darwin_arm64"]
} |
For a follow-up, does darwin_arm64 arch work now? |
It does work now! Did that GCC build require manual patching? How should I regard the integrity of this compiler vs some of the other OS compilers? Won't they all generate slightly different firmware binary since they're different GCC binaries themselves? Is any one system more reliable/trusted than another? |
Just my misunderstanding of the question 🤷 The repo above was about actual darwin_arm64 binaries possibility, but that's going to happen some time in the future. |
See esp8266/Arduino#8393 Missed when updating to Core 3.1.x, fix optimisation bug(s)
See esp8266/Arduino#8393 Missed when updating to Core 3.1.x, fix optimisation bug(s)
Fixes a hard-to-track bug in GCC 10.x. earlephilhower/newlib-xtensa#19 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102115 GCC 10.3 had an issue with addressing constant integer literals which would result in crazy offsets being used and random crashes in production. Update with an upstream GCC 11 bugfix by @jjsuwa-sys3175 earlephilhower/esp-quick-toolchain#31 https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=dcb2873cd32b263643bfd9d1298b35d6cd028f0a
Fixes a hard-to-track bug in GCC 10.x.
earlephilhower/newlib-xtensa#19
GCC 10.3 had an issue with addressing constant literals which would result
in crazy offsets being used and random crashes in production. Update
with an upstream GCC 11 bugfix.