GCC: xtensa: backport patch from upstream #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR relieves the problem (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102115): b552c4e601c7fdc4d341e29cc1ed6081d42b00d0 "gcc: xtensa: fix PR target/102115"
jjsuwa-sys3175
changed the title
jcmvbkbc
reviewed
Sep 8, 2021
Makefile
Outdated
| @@ -254,6 +254,7 @@ configure += --enable-languages=c,c++ | |||
| configure += --enable-lto | |||
| configure += --enable-static=yes | |||
| configure += --disable-libstdcxx-verbose | |||
| configure += --enable-checking=all | |||
There was a problem hiding this comment.
That makes sense for the gcc development, but may degrade compiler performance for the end users.
There was a problem hiding this comment.
it's just testing purpose and will be reverted
with `--enable-checking=all`, earlephilhower@ed86506 surely inhibits ICE such as: ``` /tmp/esp-quick-toolchain/repo/newlib/newlib/libc/stdlib/__exp10.c:19:20: internal compiler error: RTL check: expected code 'const_int', have 'symbol_ref' in xtensa_emit_move_sequence, at config/xtensa/xtensa.c:1079 ``` by the way, however, `--enable-checking=all` reveals another issue; building stops by ICE in `.stage.LINUX.libstdcpp`: ``` In file included from /tmp/esp-quick-toolchain/arena.x86_64/gcc-gnu/xtensa-lx106-elf/libstdc++-v3/include/bits/hashtable.h:35, from /tmp/esp-quick-toolchain/arena.x86_64/gcc-gnu/xtensa-lx106-elf/libstdc++-v3/include/unordered_map:46, from /tmp/esp-quick-toolchain/repo/gcc-gnu/libstdc++-v3/include/precompiled/stdc++.h:117: /tmp/esp-quick-toolchain/arena.x86_64/gcc-gnu/xtensa-lx106-elf/libstdc++-v3/include/bits/hashtable_policy.h:787:23: internal compiler error: in discriminator_for_local$ | __throw_out_of_range(__EXCSTR(__N("_Map_base::at"))); | ^~~~~~~~ 0x5fe038 discriminator_for_local_entity /tmp/esp-quick-toolchain/repo/gcc-gnu/gcc/cp/mangle.c:1910 (snip) ``` ``` static int discriminator_for_local_entity (tree entity) { if (!DECL_LANG_SPECIFIC (entity)) { /* Some decls, like __FUNCTION__, don't need a discriminator. */ gcc_checking_assert (DECL_ARTIFICIAL (entity)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ return 0; } else if (tree disc = DECL_DISCRIMINATOR (entity)) return TREE_INT_CST_LOW (disc); else /* The first entity with a particular name doesn't get DECL_DISCRIMINATOR set up. */ return 0; } ``` (https://github.com/gcc-mirror/gcc/blob/releases/gcc-10.3.0/gcc/cp/mangle.c#L1910) but the abovementioned issue seems not to be related to this PR and should be posted as detached issue/PR, i guess. then, this reverts commit 0b97526.
jjsuwa-sys3175
changed the title
earlephilhower
approved these changes
Nov 27, 2021
mcspr
pushed a commit
to esp8266/Arduino
that referenced
this pull request
Dec 2, 2021
Fixes a hard-to-track bug in GCC 10.x. earlephilhower/newlib-xtensa#19 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102115 GCC 10.3 had an issue with addressing constant integer literals which would result in crazy offsets being used and random crashes in production. Update with an upstream GCC 11 bugfix by @jjsuwa-sys3175 earlephilhower/esp-quick-toolchain#31 https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=dcb2873cd32b263643bfd9d1298b35d6cd028f0a
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
Fixes a hard-to-track bug in GCC 10.x. earlephilhower/newlib-xtensa#19 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102115 GCC 10.3 had an issue with addressing constant integer literals which would result in crazy offsets being used and random crashes in production. Update with an upstream GCC 11 bugfix by @jjsuwa-sys3175 earlephilhower/esp-quick-toolchain#31 https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=dcb2873cd32b263643bfd9d1298b35d6cd028f0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR relieves the problem (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102115 and earlephilhower/newlib-xtensa#19):
gcc-mirror/gcc@b552c4e "gcc: xtensa: fix PR target/102115"