Comments in BLEAdvertising are wrong/misleading #10511
Assignees
Labels
Status: Awaiting triage
Issue is waiting for triage
Comments
thomasw-mitutoyo-ctl
added
the
Status: Awaiting triage
|
Thanks @thomasw-mitutoyo-ctl for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Board
not board related
Device Description
not board related
Hardware Configuration
not board related
Version
latest master (checkout manually)
IDE Name
none
Operating System
none
Flash frequency
none
PSRAM enabled
yes
Upload speed
none
Description
I was reading the code of BLEAdvertising() in order to understand the inner details and adapt my project to it.
I noticed that the code has different comments which do not match the implementation.
Several advertising types are different in the comments compared to the implementation. The implementation seems to be correct but the comment was probably copy/pasted and not adapted afterwards.
Example:
arduino-esp32/libraries/BLE/src/BLEAdvertising.cpp
Line 355 in 3502b9c
The comment says 0x02, but later it uses 0x03:
arduino-esp32/libraries/BLE/src/BLEAdvertising.cpp
Line 357 in 3502b9c
Sketch
Debug Message
Other Steps to Reproduce
none
I have checked existing issues, online documentation and the Troubleshooting Guide
The text was updated successfully, but these errors were encountered: