-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ble): Fixed typos (or copy/paste issues) in comments for AD types in BLEAdvertising #10512
fix(ble): Fixed typos (or copy/paste issues) in comments for AD types in BLEAdvertising #10512
Conversation
👋 Hello thomasw-mitutoyo-ctl, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Target to master - 3.0.8 and 3.1.0-RC2 |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit e38a696. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you @thomasw-mitutoyo-ctl for the PR.
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Fix #10511
Description of Change
Changes in comments only. You should see all AD type codes in the surrounding code provided by the diff.
Impact: improve readability and understanding of the code for future readers (like myself)
Tests scenarios
None. This is just related to reading of the source code.
Related links
Closes #10511
#10511