Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed SOC_I2C_NUM to SOC_HP_I2C_NUM #10453

Closed
wants to merge 1 commit into from

Conversation

sivar2311
Copy link
Contributor

@sivar2311 sivar2311 commented Oct 12, 2024

Description of Change

Changed SOC_I2C_NUM to SOC_HP_I2C_NUM as suggested by Jason2866 and commented by igrr

Tests scenarios

none

Related links

5d873c0#commitcomment-147823189

Copy link
Contributor

github-actions bot commented Oct 12, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "changed SOC_I2C_NUM to SOC_HP_I2C_NUM":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello sivar2311, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8d2055b

Copy link
Contributor

Test Results

0 files   -  56  0 suites   - 56   0s ⏱️ - 4m 14s
0 tests  -  21  0 ✅  -  21  0 💤 ±0  0 ❌ ±0 
0 runs   - 135  0 ✅  - 135  0 💤 ±0  0 ❌ ±0 

Results for commit 8d2055b. ± Comparison against base commit e27a050.

sivar2311 referenced this pull request Oct 12, 2024
…_NUM (#10408)

The ESP32, ESP32-S and ESP32-H series have two I2C interfaces, while the ESP32-C series has only one.
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -200💚 -0.010.00💚 -800💚 -0.430.00
ESP32S2💚 -200💚 -0.010.00💚 -800💚 -0.570.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2💚 -200💚 -0.010.00💚 -800💚 -0.610.00
ESP32💚 -200💚 -0.010.00💚 -800💚 -0.390.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Wire/examples/WireMaster💚 -20💚 -72💚 -20💚 -800000💚 -20💚 -80💚 -20💚 -80
Wire/examples/WireScan💚 -20💚 -80💚 -20💚 -720000💚 -20💚 -80💚 -20💚 -72
Wire/examples/WireSlave💚 -20💚 -72💚 -20💚 -800000💚 -20💚 -80💚 -20💚 -80

@Jason2866
Copy link
Collaborator

@sivar2311 for master based on IDF 5.1.x it is fine as it is. For branch release/v3.1 it is already fixed.

@lucasssvaz
Copy link
Collaborator

This fix is not needed for master and it is already applied in the release/v3.1.x branch. Thanks for the contribution nonetheless 😄

@lucasssvaz lucasssvaz closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants