-
Notifications
You must be signed in to change notification settings - Fork 7.6k
replaced original BLE_iBeacon.ino example with a known-good one #7470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Human, I am testing the example and can say, that this new one works better. Tested on ESP32 + ESP32-C3 |
@Human Can you please take a look on my comment above? Thanks |
@P-R-O-C-H-Y It will take me some time to be able to test this, but which app on which platform did you use? |
void loop() { | ||
} | ||
/* | ||
Based on 31337Ghost's reference code from https://github.com/nkolban/esp32-snippets/issues/385#issuecomment-362535434 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Human Please, it seems a lot of lines are still similar to the example created by Neil Kolban.
Can you please mentioned in the header that this example is "modified version by 31337Ghost User " of the original example from Neil?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check revised comment.
@Human I did test on ESP32-C3 and with HONOR phone running Android 10 + app called nRF Connect (also tried another app, but got same behaviour). |
|
@P-R-O-C-H-Y I was able to reproduce what you saw, but I don't know enough about BLE or iBeacons to fix the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Human please take a look on my comment :)
@Human could you please rebase this PR |
3445c16
to
40bd410
Compare
Description of Change
I had no luck getting the original
BLE_iBeacon.ino
code to work as expected with iBeacon scanners, but the included reference code worked completely. Thanks to @31337Ghost for writing it! I am simply submitting the PR.Tests scenarios
Tested on DOIT ESP32 DEVKIT V1, using various scanner client apps on Android devices.
Related links
Closes #7360