Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-S3 PowerFeather Fixes #9052

Merged
merged 3 commits into from
Jan 8, 2024
Merged

ESP32-S3 PowerFeather Fixes #9052

merged 3 commits into from
Jan 8, 2024

Conversation

powerfeatherdev
Copy link
Contributor

@powerfeatherdev powerfeatherdev commented Dec 31, 2023

Description of Change

Follow up to #8889.

  • Adds missing pin definitions for D7 and D8.
  • Fixes pin definitions for ALARM and EN
  • Makes CDC on boot enabled default.
  • Remove partition schemes for flash sizes other than what is on PowerFeather (8MB)
  • Add other 8MB schemes: default FATFS variation, large FATFS and SPIFFS

Tests scenarios

  • Internal tests of all publicly exposed pin definitions are ok.
  • CDC on boot is default for PowerFeather confirmed.
  • Partition schemes build and flash, including newly added ones. The flashed test firmware lists partitions using esp_partition_xxx APIs, verified it matches the csv files.

Related links

First PR: #8889
Website: https://www.powerfeather.dev/

Copy link
Contributor

github-actions bot commented Dec 31, 2023

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Enable CDC on boot":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix and add pin definitions":
    • summary looks empty
    • type/action looks empty
  • the commit message "Use partition schemes appropriate for flash size":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello powerfeatherdev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 97f3a44

@powerfeatherdev powerfeatherdev marked this pull request as ready for review January 6, 2024 02:06
@powerfeatherdev
Copy link
Contributor Author

powerfeatherdev commented Jan 6, 2024

Add pins D7, D8
Correct pin numbers for ALARM and EN
Also adds another partition scheme based of off default_8MB, but fat
partition.
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jan 8, 2024
@me-no-dev me-no-dev merged commit 53aa8c8 into espressif:master Jan 8, 2024
47 checks passed
@powerfeatherdev
Copy link
Contributor Author

Thank you @P-R-O-C-H-Y!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants