Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32-S3 PowerFeather Support for v2.x #9325

Merged
merged 8 commits into from
Mar 5, 2024
Merged

ESP32-S3 PowerFeather Support for v2.x #9325

merged 8 commits into from
Mar 5, 2024

Conversation

powerfeatherdev
Copy link
Contributor

@powerfeatherdev powerfeatherdev commented Mar 3, 2024 •
edited
Loading

Cherry-picked commits from #8889 and #9052, but for release/v2.x.

@powerfeatherdev
Copy link
Contributor Author

powerfeatherdev commented Mar 3, 2024 •
edited
Loading

Hello @P-R-O-C-H-Y, in #8889 (comment) you mentioned that these definitions are no longer necessary. I thought it was only for v3, but is it also the case for v2 (since apparently all checks have passed)?

@P-R-O-C-H-Y
Copy link
Member

Hello @P-R-O-C-H-Y, in #8889 (comment) you mentioned that these definitions are no longer necessary. I thought it was only for v3, but is it also the case for v2 (since apparently all checks have passed)?

Hello @powerfeatherdev, our core is not using those definitions anywhere, so as you said all check passed without that. But there are lot of 3rd party libraries and examples which may use those definitions. So if they are not defined for the board, the user may get in trouble :)

@powerfeatherdev
Copy link
Contributor Author

@P-R-O-C-H-Y Thanks for the clarification.

@powerfeatherdev powerfeatherdev marked this pull request as ready for review March 3, 2024 09:49
@powerfeatherdev
Copy link
Contributor Author

@SuGlider @me-no-dev @P-R-O-C-H-Y Please take a look.

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: 3rd party Boards Status: Pending Merge Pull Request is ready to be merged labels Mar 4, 2024
@VojtechBartoska VojtechBartoska added this to the 2.0.15 milestone Mar 4, 2024
@me-no-dev me-no-dev merged commit d75795f into espressif:release/v2.x Mar 5, 2024
48 of 49 checks passed
@powerfeatherdev powerfeatherdev deleted the esp32s3_powerfeather_support_v2.x branch March 5, 2024 10:41
powerfeatherdev added a commit to PowerFeather/arduino-esp32 that referenced this pull request Mar 26, 2024
@powerfeatherdev
ESP32-S3 PowerFeather Support for v2.x (espressif#9325)
4fcd57a 
* Add support for ESP32-S3 PowerFeather

* Replace GPIO_NUM_X with just the pin number

* Pattern powerfeather entries after generic s3 board

* Remove redefinitions, add pin aliases to pins_arduino.h

* Fix and add pin definitions

Add pins D7, D8
Correct pin numbers for ALARM and EN

* Enable CDC on boot

* Use partition schemes appropriate for flash size

Also adds another partition scheme based of off default_8MB, but fat
partition.

* Add some required definitions to pins_arduino.h
@powerfeatherdev powerfeatherdev mentioned this pull request Apr 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@powerfeatherdev @P-R-O-C-H-Y @me-no-dev @VojtechBartoska