-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve USBVendor Example #9349
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and working well.
@lucasssvaz Suggesting to change Button Pressed/ Released message for some 64bytes long message so it gets printed to Server immediately.
Also adding a comment to the code would be nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of Change
Improves USBVendor example by adding the flush method and adding WebUSB console hosted inside the documentation.
Tests scenarios
Tested with ESP32-S3 DevKit
Related links
Closes #8235