Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): Add note about default pin changes to migration guide #9507

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Add note to the migration guide about default pin changes for UART. Also fix some formatting issues.

@lucasssvaz lucasssvaz added Type: Documentation Issue pertains to Documentation of Arduino ESP32 Peripheral: UART 3.0 migration issue relates to migration from 2.X to 3.X version labels Apr 14, 2024
@lucasssvaz lucasssvaz self-assigned this Apr 14, 2024
Copy link
Contributor

github-actions bot commented Apr 14, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b869126

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Apr 15, 2024
@lucasssvaz lucasssvaz removed the Status: Pending Merge Pull Request is ready to be merged label Apr 15, 2024
@lucasssvaz
Copy link
Collaborator Author

@SuGlider Let's wait #9515 be merged first before putting the Pending Merge tag. This way the bot won't be crazy with unrelated changes 😆

@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged labels Apr 15, 2024
@me-no-dev me-no-dev merged commit a45b5af into espressif:master Apr 15, 2024
53 checks passed
@lucasssvaz lucasssvaz deleted the doc/pin_change branch April 15, 2024 20:35
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 migration issue relates to migration from 2.X to 3.X version Peripheral: UART Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants