Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor repository with pre-commit hooks #9515

Merged
merged 40 commits into from
Apr 15, 2024
Merged

Refactor repository with pre-commit hooks #9515

merged 40 commits into from
Apr 15, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Refactor all code base with the new pre-commit hooks.

Tests scenarios

Tested locally and with CI.

lucasssvaz and others added 30 commits February 6, 2024 00:26
@lucasssvaz
Add Config
e5910c2
@lucasssvaz
Add Cache and remove pre-commit action
bc0c991
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
d3e6f51
@lucasssvaz
Remove freeze
7265074
@lucasssvaz
Fix
bb75101
@lucasssvaz
Merge branch 'master' into ci/style_check
455c8fd
@lucasssvaz
Merge branch 'master' into ci/style_check
306459b
@lucasssvaz
Update action
26308fe
@lucasssvaz
Use latest stable Python 3 version
ee175a1
@lucasssvaz
Merge branch 'master' into ci/style_check
f29f962
@SuGlider
Merge branch 'master' into ci/style_check
d7699a6
@lucasssvaz
Improve caching
25d9d41
@lucasssvaz
Merge branch 'master' into ci/style_check
edb993f
@lucasssvaz
Merge branch 'master' into ci/style_check
2b2580c
@lucasssvaz
Merge branch 'master' into ci/style_check
cfd7a41
@lucasssvaz
Merge branch 'master' into ci/style_check
1533703
@lucasssvaz
Merge branch 'master' into ci/style_check
001c3bd
@lucasssvaz
Merge branch 'master' into ci/style_check
16212dd
@lucasssvaz
Merge branch 'master' into ci/style_check
b350640
@lucasssvaz
Merge branch 'master' into ci/style_check
c67737d
@lucasssvaz
Merge branch 'master' into ci/style_check
3f14074
@lucasssvaz
Improve cache tag
7bb7270
@lucasssvaz
Improve bot message
f09bd1c
@lucasssvaz
Merge branch 'master' into ci/style_check
770db61
@lucasssvaz
Merge branch 'ci/style_check' into refactoring/spelling
0464877
@lucasssvaz
fix(typos): Fix typos
b139724
@lucasssvaz
fix(typos): Fix more typos
9fece7a
@lucasssvaz
refactor(udp_server): Convert script from Python 2 to 3
1e2bb9a
@lucasssvaz
Merge branch 'ci/style_check' into refactor/coding_style
8ffd213
@lucasssvaz
Merge branch 'refactoring/spelling' into refactor/coding_style
575f5fa
@lucasssvaz lucasssvaz added hil_test Run Hardware Tests lib_test Run External Libraries Test labels Apr 15, 2024
@lucasssvaz lucasssvaz self-assigned this Apr 15, 2024
@lucasssvaz lucasssvaz added this to the 3.0.0-RC2 milestone Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add Cache and remove pre-commit action":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add Config":
    • summary looks empty
    • type/action looks empty
  • the commit message "Black formatting":
    • summary looks empty
    • type/action looks empty
  • the commit message "Clang-format fixes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix flake and make Vale manual":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix flake and reformat":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix whitespace":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "Improve bot message":
    • summary looks empty
    • type/action looks empty
  • the commit message "Improve cache tag":
    • summary looks empty
    • type/action looks empty
  • the commit message "Improve caching":
    • summary looks empty
    • type/action looks empty
  • the commit message "Line endings":
    • summary looks empty
    • type/action looks empty
  • the commit message "Manual fixes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Prettier fixes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove freeze":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update action":
    • summary looks empty
    • type/action looks empty
  • the commit message "Use latest stable Python 3 version":
    • summary looks empty
    • type/action looks empty
  • the commit message "[pre-commit.ci lite] apply automatic fixes":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(typos): Fix more typos":
    • summary looks too short
  • the commit message "fix(typos): Fix typos":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 40 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 121212), you might consider splitting it into smaller PRs

👋 Hello lucasssvaz, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f7796d4

@lucasssvaz lucasssvaz removed the hil_test Run Hardware Tests label Apr 15, 2024
@lucasssvaz lucasssvaz mentioned this pull request Apr 15, 2024
Merged
@lucasssvaz
Copy link
Collaborator Author

CI hardware tests failing are unrelated to this PR. Looks like there some issue on the runners.

@me-no-dev me-no-dev merged commit da5c6ab into espressif:master Apr 15, 2024
135 of 171 checks passed
@lucasssvaz lucasssvaz deleted the refactor/coding_style branch April 15, 2024 19:51
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
@lucasssvaz @pre-commit-ci-lite
@SuGlider @P-R-O-C-H-Y
Refactor repository with pre-commit hooks (espressif#9515)
63e613d 
* Add Config

* Add Cache and remove pre-commit action

* [pre-commit.ci lite] apply automatic fixes

* Remove freeze

* Fix

* Update action

* Use latest stable Python 3 version

* Improve caching

* Improve cache tag

* Improve bot message

* fix(typos): Fix typos

* fix(typos): Fix more typos

* refactor(udp_server): Convert script from Python 2 to 3

* Fix whitespace

* Clang-format fixes

* Prettier fixes

* Black formatting

* Manual fixes

* Line endings

* Fix flake and make Vale manual

* Fix flake and reformat

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
aIecxs pushed a commit to aIecxs/arduino-esp32 that referenced this pull request Oct 24, 2024
@lucasssvaz @pre-commit-ci-lite @SuGlider
Refactor repository with pre-commit hooks (espressif#9515)
8f41cb7 
* Add Config

* Add Cache and remove pre-commit action

* [pre-commit.ci lite] apply automatic fixes

* Remove freeze

* Fix

* Update action

* Use latest stable Python 3 version

* Improve caching

* Improve cache tag

* Improve bot message

* fix(typos): Fix typos

* fix(typos): Fix more typos

* refactor(udp_server): Convert script from Python 2 to 3

* Fix whitespace

* Clang-format fixes

* Prettier fixes

* Black formatting

* Manual fixes

* Line endings

* Fix flake and make Vale manual

* Fix flake and reformat

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

@SuGlider SuGlider Awaiting requested review from SuGlider

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

Assignees

@lucasssvaz lucasssvaz

Labels
lib_test Run External Libraries Test
Projects
None yet
Milestone
3.0.0-RC2
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasssvaz @me-no-dev @SuGlider