Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix output channel interrupt #1174

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix output channel interrupt #1174

merged 1 commit into from
Apr 26, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Apr 1, 2024

Description

Add tag for Output channel just the first time and replace it when a new tag is received.
Add message after flashing to use the monitor command

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "SDK Configuration Editor". Tag should be printed only once at the beginning.
  2. Start OpenOCD. The SDK Configuration Editor end tag should appear before OpenOCD tag.
  3. Observe results.

How has this been tested?

Manual testing based on steps above.

Test Configuration:

  • ESP-IDF Version: 5.2
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 added this to the v1.8.0 milestone Apr 1, 2024
@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Probably we should unify this under same structure.
In some cases it is "Monitor YOUR device", in other "Monitor device".

image

image

@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Apr 18, 2024

@brianignacio5

do see opening tag
image

and closing tag 👍

image

@brianignacio5
Copy link
Collaborator Author

@brianignacio5 hi !

Probably we should unify this under same structure. In some cases it is "Monitor YOUR device", in other "Monitor device".

image

image

Fixed in #1178 because it will update commands anyway.

@brianignacio5 brianignacio5 merged commit 4eaaa5f into master Apr 26, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/logger-output branch April 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants