Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation using l10n vscode api #1178

Merged
merged 10 commits into from
May 13, 2024
Merged

Translation using l10n vscode api #1178

merged 10 commits into from
May 13, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Apr 11, 2024

Description

Use vscode.l10n.t() for source code translation to reduce translation files and phrases duplication.
Add missing translation from package.json to fix GitHub issue.
Add Portuguese translation.

Fixes #1165
Fixes #567

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

This PR provides a list of translations. You need to switch vscode language to observer commands and text translation.

  1. Click on "Configure display language" vscode command. Choose one of our supported languages (Chinese, English, Spanish, Russian).
  2. Execute action. Vscode language should be changed and extension commands and text should also change.
  3. Observe results.
  • Expected behaviour:
  • Extension language change to vscode new language.

How has this been tested?

Manual Testing

Test Configuration:

  • ESP-IDF Version: Irrelevant
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the Feature A new feature label Apr 11, 2024
@brianignacio5 brianignacio5 added this to the v1.8.0 milestone Apr 11, 2024
@brianignacio5 brianignacio5 self-assigned this Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Tested under:
OS - Windows 10
ESP-IDF: v5.2

Do see commands translated to supported languages (Chinese, English, Spanish, Russian).
able to build - flash - monitor.

LGTM 👍

@brianignacio5 brianignacio5 merged commit a3291c6 into master May 13, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the feature/i10n branch May 13, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode扩展i18n的问题 (VSC-1329)
3 participants