Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape::Rhomboid::calculate_distance broken #868

Closed
rempferg opened this issue Oct 8, 2016 · 3 comments · Fixed by #2756
Closed

Shape::Rhomboid::calculate_distance broken #868

rempferg opened this issue Oct 8, 2016 · 3 comments · Fixed by #2756

Comments

@rempferg
Copy link
Member

rempferg commented Oct 8, 2016

It still compiles and runs, but produces incorrect distances and distance vectors. It most likely got broken when it was converted into a Shape.

@fweik
Copy link
Contributor

fweik commented Oct 9, 2016

I have written some basic general unit tests for the shape functions that I have not merged yet. My best idea was to get the normal and distance on a bunch of points, and then check if point - (dist*normal) is actually on the surface. I think this is similar to what you did manually to check the distance functions. Of course this is only a necessary and not a sufficient condition on the distance function, but I could not come up with something better yet. If you can think of sth, shoot..

@RudolfWeeber RudolfWeeber added this to the Espresso 4.0 milestone Nov 28, 2016
@RudolfWeeber RudolfWeeber modified the milestone: Espresso 4.0 Sep 6, 2017
@RudolfWeeber
Copy link
Contributor

What do we do about this. There are some 500 lines of untested (and according to Georg's report) wrong code.
If there's no application in sight, we might remove the Rhomboid shape.

@fweik
Copy link
Contributor

fweik commented Jan 31, 2019

First of all check how much of it can be accomplished by library code? I think boost.geometry should be helpful here, but I have not checked.

itischler added a commit to itischler/espresso that referenced this issue Apr 25, 2019
@itischler itischler mentioned this issue Apr 25, 2019
4 tasks
bors bot added a commit that referenced this issue Apr 25, 2019
2756: Rhomboid fix r=fweik a=itischler

Fixes #868 

Description of changes:
 -  fixed the rhomboid shape
 -  testcase now checks the geometry of a cuboid


PR Checklist
------------
 - [ ] Tests?
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


Co-authored-by: itischler <ingo.tischler@gmx.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors bors bot closed this as completed in #2756 Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants