-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shape::Rhomboid::calculate_distance broken #868
Comments
I have written some basic general unit tests for the shape functions that I have not merged yet. My best idea was to get the normal and distance on a bunch of points, and then check if point - (dist*normal) is actually on the surface. I think this is similar to what you did manually to check the distance functions. Of course this is only a necessary and not a sufficient condition on the distance function, but I could not come up with something better yet. If you can think of sth, shoot.. |
What do we do about this. There are some 500 lines of untested (and according to Georg's report) wrong code. |
First of all check how much of it can be accomplished by library code? I think boost.geometry should be helpful here, but I have not checked. |
2756: Rhomboid fix r=fweik a=itischler Fixes #868 Description of changes: - fixed the rhomboid shape - testcase now checks the geometry of a cuboid PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: itischler <ingo.tischler@gmx.de> Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
It still compiles and runs, but produces incorrect distances and distance vectors. It most likely got broken when it was converted into a Shape.
The text was updated successfully, but these errors were encountered: