Rhomboid fix #2756
Merged
Rhomboid fix #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2756 +/- ##
=======================================
+ Coverage 80% 81% +1%
=======================================
Files 508 508
Lines 27055 27121 +66
=======================================
+ Hits 21884 22214 +330
+ Misses 5171 4907 -264
Continue to review full report at Codecov.
|
fweik
approved these changes
Apr 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 25, 2019
2756: Rhomboid fix r=fweik a=itischler Fixes #868 Description of changes: - fixed the rhomboid shape - testcase now checks the geometry of a cuboid PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: itischler <ingo.tischler@gmx.de> Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #868
Description of changes:
PR Checklist