Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix espressomd.has_features for exact match between tested and avilab… #3318

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

RudolfWeeber
Copy link
Contributor

…le features

Fixes #

Description of changes:

PR Checklist

  • Tests?
    • Interface
    • Core
  • Docs?

@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #3318 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3318   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         536     536           
  Lines       25550   25564   +14     
======================================
+ Hits        21989   21992    +3     
- Misses       3561    3572   +11
Impacted Files Coverage Δ
src/core/integrators/velocity_verlet_npt.cpp 85% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/coulomb.cpp 79% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 86% <0%> (-1%) ⬇️
...core/electrostatics_magnetostatics/p3m-dipolar.cpp 81% <0%> (-1%) ⬇️
src/utils/include/utils/math/rotation_matrix.hpp 100% <0%> (ø) ⬆️
src/core/electrostatics_magnetostatics/fft.cpp 86% <0%> (ø) ⬆️
src/core/unit_tests/MpiCallbacks_test.cpp 100% <0%> (ø) ⬆️
src/core/BoxGeometry.hpp 100% <0%> (ø) ⬆️
src/core/immersed_boundary/ibm_tribend.cpp 91% <0%> (ø) ⬆️
src/core/unit_tests/ScriptInterface_test.cpp 20% <0%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62152df...8c4e4a8. Read the comment docs.

@jngrad jngrad added this to the 4.1.2 milestone Nov 18, 2019
@jngrad
Copy link
Member

jngrad commented Nov 18, 2019

bors r=fweik

bors bot added a commit that referenced this pull request Nov 18, 2019
3318: Fix espressomd.has_features for exact match between tested and avilab… r=fweik a=RudolfWeeber

…le features

Fixes #

Description of changes:
 - 


PR Checklist
------------
 - [ ] Tests?
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


3325: core: p3m: Factored out common local mesh calculation from p3m/dp3m r=jngrad a=fweik



Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Nov 18, 2019

Build failed (retrying...)

@jngrad
Copy link
Member

jngrad commented Nov 18, 2019

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 18, 2019

Canceled

@jngrad
Copy link
Member

jngrad commented Nov 18, 2019

bors r=fweik

bors bot added a commit that referenced this pull request Nov 18, 2019
3318: Fix espressomd.has_features for exact match between tested and avilab… r=fweik a=RudolfWeeber

…le features

Fixes #

Description of changes:
 - 


PR Checklist
------------
 - [ ] Tests?
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


3325: core: p3m: Factored out common local mesh calculation from p3m/dp3m r=jngrad a=fweik



Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Nov 18, 2019

Build succeeded

@bors bors bot merged commit 8c4e4a8 into espressomd:python Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants