Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: p3m: Factored out common local mesh calculation from p3m/dp3m #3325

Merged
merged 1 commit into from
Nov 18, 2019
Merged

core: p3m: Factored out common local mesh calculation from p3m/dp3m #3325

merged 1 commit into from
Nov 18, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Nov 18, 2019

No description provided.

@fweik fweik requested a review from jngrad November 18, 2019 12:59
jngrad
jngrad approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI

@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #3325 into python will decrease coverage by <1%.
The diff coverage is 96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3325    +/-   ##
=======================================
- Coverage      86%     86%    -1%     
=======================================
  Files         538     538            
  Lines       25411   25305   -106     
=======================================
- Hits        21894   21779   -115     
- Misses       3517    3526     +9
Impacted Files Coverage Δ
.../core/electrostatics_magnetostatics/p3m-common.hpp 100% <ø> (ø) ⬆️
...core/electrostatics_magnetostatics/p3m-dipolar.cpp 82% <100%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <100%> (-1%) ⬇️
.../core/electrostatics_magnetostatics/p3m-common.cpp 78% <95%> (+4%) ⬆️
src/core/global.cpp 75% <0%> (-8%) ⬇️
...rc/core/electrostatics_magnetostatics/scafacos.cpp 64% <0%> (-6%) ⬇️
src/core/electrostatics_magnetostatics/dipole.cpp 58% <0%> (-6%) ⬇️
src/core/object-in-fluid/oif_global_forces.cpp 80% <0%> (-1%) ⬇️
src/core/grid_based_algorithms/lb.cpp 95% <0%> (-1%) ⬇️
...rc/utils/include/utils/math/triangle_functions.hpp 90% <0%> (-1%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39387f...d5b908c. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Nov 18, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 18, 2019
@bors @RudolfWeeber @fweik
Merge #3318 #3325
4e19e38 
3318: Fix espressomd.has_features for exact match between tested and avilab… r=fweik a=RudolfWeeber

…le features

Fixes #

Description of changes:
 - 


PR Checklist
------------
 - [ ] Tests?
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


3325: core: p3m: Factored out common local mesh calculation from p3m/dp3m r=jngrad a=fweik



Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Nov 18, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request Nov 18, 2019
@bors @fweik
Merge #3325
91bc71e 
3325: core: p3m: Factored out common local mesh calculation from p3m/dp3m r=jngrad a=fweik



Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@jngrad
Copy link
Member

jngrad commented Nov 18, 2019

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 18, 2019

Canceled

@jngrad
Copy link
Member

jngrad commented Nov 18, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 18, 2019
@bors @RudolfWeeber @fweik
Merge #3318 #3325
a4d0ed2 
3318: Fix espressomd.has_features for exact match between tested and avilab… r=fweik a=RudolfWeeber

…le features

Fixes #

Description of changes:
 - 


PR Checklist
------------
 - [ ] Tests?
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


3325: core: p3m: Factored out common local mesh calculation from p3m/dp3m r=jngrad a=fweik



Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Nov 18, 2019

Build succeeded

@bors bors bot merged commit d5b908c into espressomd:python Nov 18, 2019
@fweik fweik deleted the p3m_local_mesh branch August 27, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
Core Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fweik @jngrad