Allow wasm-xlsxwriter to be used from both from web and nodejs

[henrikekblad]

No description provided.

[kenkoooo]

Thank you for your contribution! Could you provide guidance on how we can test it to ensure it works as expected?

[henrikekblad]

Updated tests to use the new web path

[henrikekblad]

This is how I use it from the node-side:

const {
	Format,
	FormatAlign,
	RichString,
	FormatBorder,
	FormatScript,
	DocProperties,
	Color,
	Workbook
} = require('wasm-xlsxwriter');

function exportXlsx(columns, rows) {
	const workbook = new Workbook();
	const props = new DocProperties();
	props.setCompany('Test Inc.');
	workbook.setProperties(props);
	const worksheet = workbook.addWorksheet();
	worksheet.setName('Export');
	const headerStyle = new Format().setAlign(FormatAlign.Top).setAlign(FormatAlign.Left).setTextWrap().setBackgroundColor(Color.rgb(0xe2eee8)).setBorderBottom(FormatBorder.Medium).setBorderBottomColor(Color.rgb(0x0B703D)).setBorderRight(FormatBorder.Thin).setBorderRightColor(Color.rgb(0x0B703D));
	const defaultStyle = new Format().setTextWrap().setAlign(FormatAlign.Top);
	// Write header here [code removed - too complex for this example]
	// Write sheet data
	for (const [y, row] of rows.entries()) {
		for (const [x, col] of row.entries()) {
			worksheet.writeWithFormat(y + 1, x, col, defaultStyle);
		}
	}

	worksheet.setFreezePanes(1, 0);
	worksheet.autofilter(0, 0, rows.length, columns.length - 1);
	const buffer = workbook.saveToBufferSync();
	return buffer;
});

Note that no init-metod is needed.

[tamaroning]

This should be separate script commands. It then requires changes to github workflows

[henrikekblad]

I guess only you have access to the github workflows? Maybe it's better you do the separation after the PR has been merged?

[kenkoooo]

It seems that we need to put more effort into supporting both browsers and Node runtimes. For example, brotli-wasm has its own build script to achieve that. The bundler target can be an option, but according to the documentation, only Webpack supports this feature at this time.

[henrikekblad]

Ok, I'll follow the brotli example. They seem to be working on an inline target that may be an option in the future.

For reference:
rustwasm/wasm-pack#1334
rustwasm/wasm-bindgen#4065

[kenkoooo]

It seems that your change no longer supports the web, such as Next.js. I added a test in #26 to ensure that it still works with Next.js. I hope it might be helpful.

[henrikekblad]

Ok thanks, cross-env seems to fix the problem @kenkoooo.

[kenkoooo]

I'm really sorry, but the CI setup was incorrect. It's already been fixed in #28. Would you mind retrying with the latest version? I apologize for the inconvenience, and thank you for your understanding.

[henrikekblad]

Are you sure about the rollback @kenkoooo? I actually experienced problem with #26 when building locally without the cross-env fix.

[kenkoooo]

The latest main branch passes all tests. Could you please rebase your branch onto it? Thank you.

[henrikekblad]

Could this be related?

vercel/next.js#61921

[kenkoooo]

I'm not entirely sure how Next.js bundles libraries, but some libraries, such as nextjs-auth0, provide both client-side and server-side functionalities.

[kenkoooo]

Would you mind avoiding the use of absolute paths and using package names instead? We'd like to ensure that the package can be imported correctly. Could you please use something like wasm-xlsxwriter/client?

[henrikekblad]

I cannot seem to recreate the correct package-lock-file. What npm commands did you run to get a link in the lock-file? Like this:

"node_modules/wasm-xlsxwriter": {
      "resolved": "../..",
      "link": true
 }

[henrikekblad]

Ok, you guys seemed to run a newver version of npm. When I updated npm and re-created package-lock-file it seems to work.

[kenkoooo]

Thank you for your excellent work! I’ll review and merge it this week.