Added simple support for MetaProperty #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice. Could you add a test? |
|
Would you recommend adding it to Harmony.js? |
… new.target meta-property.
|
Had to add tests to a new harmony-2.5.js file that works against esprima ^2.5 due to differences in behaviour that invalidate other tests, and I didn't fancy going through and doing all the changes and potentially invalidating tests for unrelated features. |
|
Ah. OK. Looks fine. |
Constellation
added a commit
that referenced
this pull request
Dec 15, 2015
Added simple support for MetaProperty
|
Thanks!!! |
|
Any chance of pushing a release so I can pursue this through with the Istanbul team for a downstream change to add this support there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for MetaProperty node type. A very straighforward variant of the MemberExpression, with little work required. This lets syntax such as new.target get parsed in ES6 code.