This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
MetaProperty support #506
Merged
MetaProperty support #506
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2015 11:27
…oes not choke on input. Works fine with modified escodegen.
|
LGTM. I need to forward port this fix into the v1 branch as well in the instrumentation library. Will merge this PR when I'm ready to do this. |
|
Quick heads up: escodegen has published 1.8.0 that includes my fix, so in theory this is good to go. |
|
Is there a timeframe for this making it's way into the wild? |
|
Available in istanbul@0.4.3 - sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've just made a contribution to ESCodeGen to support MetaProperties, and this is the change to add the support for this into Istanbul.
The upstream dependency is: estools/escodegen#275
This will have no immediate effect until they release the upstream version. The change implements a 'skipSelf' option on the node, allowing an early bailout from the child node walker since unlike other property expressions, both 'meta' and 'property' on the MetaProperty node are just strings, and cannot have additional sub-properties added due to strings being read only.
My question is: Is this the right way to go about this? It's very hard to run the NPM test suite on Windows due to the shell scripting and Unix-paths used in places, but in some local testing this appears to work fine.