Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0: Optional catch binding support, removed CLI scripts #403

Closed

Conversation

sanex3339
Copy link
Contributor

@sanex3339 sanex3339 commented Jan 4, 2020

2.0.0:

  • Optional catch binding support
  • Removed CLI scripts
  • Increased minimal required node.js version to 8+
  • updated gulp to 4+ version to support development on node.js 12+
  • updated gulpfile.js

This is breaking PR, so, updated version to 2.0.0

@sanex3339
Copy link
Contributor Author

@michaelficarra need your review

@sanex3339
Copy link
Contributor Author

Ping

@sanex3339
Copy link
Contributor Author

@michaelficarra ping

1 similar comment
@sanex3339
Copy link
Contributor Author

@michaelficarra ping

@michaelficarra
Copy link
Member

@sanex3339 I don't like that this PR includes so many unrelated changes. I would accept a PR that just adds the optional catch binding support. The remaining changes don't seem worth it to me, but we can have conversation about that in separate PRs. Closing this, but feel free to open separate PRs for these separate features.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Jan 9, 2020

Optional catch binding is not supported by esprima right now, so, i will added espree that support it.
But espree does not support node@4.
So i updated to node@8 and fixed compilation on current LTS node 12+ by updating gulp to gulp@4.

You should understand that this project used by a thousand other projects, but it very old and step-by-step it should become more modern. At least, people who can support it should do it without problems.

Anyway, I agree with you.

@sanex3339
Copy link
Contributor Author

Will recreate this PR using acorn

@sanex3339
Copy link
Contributor Author

#405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants