-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0: Optional catch binding support, removed CLI scripts #403
2.0.0: Optional catch binding support, removed CLI scripts #403
Conversation
Sync with escodegen/master
@michaelficarra need your review |
Ping |
@michaelficarra ping |
1 similar comment
@michaelficarra ping |
@sanex3339 I don't like that this PR includes so many unrelated changes. I would accept a PR that just adds the optional catch binding support. The remaining changes don't seem worth it to me, but we can have conversation about that in separate PRs. Closing this, but feel free to open separate PRs for these separate features. |
Optional catch binding is not supported by You should understand that this project used by a thousand other projects, but it very old and step-by-step it should become more modern. At least, people who can support it should do it without problems. Anyway, I agree with you. |
Will recreate this PR using |
2.0.0:
This is breaking PR, so, updated version to 2.0.0