Optional catch binding support #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with escodegen/master
|
@michaelficarra please check this PR |
|
@michaelficarra also can you release a new version after the merge, please. |
escodegen.js
Outdated
| that.generateExpression(stmt.param, Precedence.Sequence, E_TTT), | ||
| ')' | ||
| ]; | ||
| if (!stmt.param) { |
There was a problem hiding this comment.
Always use a positive condition when there's an alternative branch. Drop the ! and swap the branches.
|
@michaelficarra fixed |
michaelficarra
approved these changes
Jan 11, 2020
|
Thank you. @michaelficarra can you release a new version? |
|
Ping, i really need this release |
|
@sanex3339, you come off as quite rude with all those pings. Please be aware that this is a volunteer effort and that things take time. Why don't you publish a fork while you're waiting? |
|
@michaelficarra please,release a new version with this fix |
|
@sanex3339 Published version 1.13.0. |
|
Thank you! |
bizob2828
pushed a commit
to Contrast-Security-OSS/escodegen
that referenced
this pull request
Apr 2, 2020
* Added support for optional-catch binding * Reverted optional catch binding condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional catch binding support