Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for Bucket.Delete() in README.md #338

Closed
wants to merge 3 commits into from
Closed

Add example for Bucket.Delete() in README.md #338

wants to merge 3 commits into from

Conversation

Sarthak2143
Copy link
Contributor

The example is similar to the examples for Bucket.Put() and Bucket.Get() functions, so it does not breaks the layout.
Signed-off-by: Sarthak2143 sarthaktomar2143@gmail.com

The example is similar to the examples for `Bucket.Put()` and `Bucket.Get()` functions, so it does not breaks the layout. Signed-off-by: Sarthak2143 <sarthaktomar2143@gmail.com> .
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Nov 13, 2022

Please signoff the commit: git rebase HEAD~1 --signoff

Sarthak2143 and others added 2 commits November 15, 2022 19:45
Co-authored-by: Benjamin Wang <wachao@vmware.com>
Co-authored-by: Benjamin Wang <wachao@vmware.com>
@ahrtr
Copy link
Member

ahrtr commented Nov 15, 2022

Please squash the commits and signoff it.

@ahrtr
Copy link
Member

ahrtr commented Nov 15, 2022

After you squash the commits into one, then execute git rebase HEAD~1 --signoff

@ahrtr ahrtr added the resurrection The PR makes sense but not responsive. So please anyone feel free to resurrect this PR label Nov 30, 2022
@ahrtr
Copy link
Member

ahrtr commented Dec 30, 2022

Added label resurrection because there is no response from the original author. Please anyone else feel free to resurrect this PR.

@cenkalti
Copy link
Member

Resurrected at #421

@ahrtr
Copy link
Member

ahrtr commented Mar 14, 2023

Superseded by #421

@ahrtr ahrtr closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resurrection The PR makes sense but not responsive. So please anyone feel free to resurrect this PR
Development

Successfully merging this pull request may close these issues.

3 participants