Add example for Bucket.Delete() in README.md #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example is similar to the examples for `Bucket.Put()` and `Bucket.Get()` functions, so it does not breaks the layout. Signed-off-by: Sarthak2143 <sarthaktomar2143@gmail.com> . Co-authored-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: Cenk Alti <cenkalti@gmail.com>
ahrtr
reviewed
Mar 14, 2023
| ```go | ||
| db.Update(func (tx *bolt.Tx) error { | ||
| b := tx.Bucket([]byte("MyBucket")) | ||
| err := b.Delete([]byte("answer")) |
There was a problem hiding this comment.
When the bucket "MyBucket" doesn't exist, then the returned b is nil; accordingly b.Delete will panic due to nil pointer error. I am thinking we should add a check something like if b != nil.
All examples in README do not have such check, so we can address this in a separate PR to update all examples. WDYT?
There was a problem hiding this comment.
I think nil check can be omitted in examples for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrect #338