-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3: log warning in case of error sending request #11452
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11452 +/- ##
==========================================
+ Coverage 64.11% 64.23% +0.11%
==========================================
Files 403 403
Lines 38081 38085 +4
==========================================
+ Hits 24416 24462 +46
+ Misses 12037 11974 -63
- Partials 1628 1649 +21
Continue to review full report at Codecov.
|
@jingyih |
a6817cc
to
05c12e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to guard these log lines with if l.lg != nil {
?
d94547b
to
0e91877
Compare
@jingyih |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just one more nit.
0e91877
to
cb8bf08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In watchGrpcStream#run, we should log the (non-nil) error when sending request.