Automated cherry pick of #11452 #12187 on release 3.4 #12189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This cherrypick is causing the following test to timeout. |
jingyih
force-pushed
the
automated-cherry-pick-of-#11452-#12187-upstream-release-3.4
branch
from
1cc74f1
to
6fcab5a
Compare
|
It turns out that we removed all nil checking for logger in master branch, but not in 3.4 branch. Just added the nil checking back to this backport. |
|
@gyuho PTAL. We need a new 3.4 patch release to be picked up by k8s v.119. |
gyuho
approved these changes
Aug 14, 2020
|
ack, will cut a patch release soon |
|
@gyuho Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11452: clientv3: log warning in case of error sending request
#12187: clientv3: remove excessive watch cancel logging