Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing copyright headers #14831

Merged

Conversation

andrewcameronsims
Copy link
Contributor

@andrewcameronsims andrewcameronsims commented Nov 23, 2022

Context #14827

Simple change to add missing copyright headers. The linked issue only mentions one file but I was able to find others in the codebase that had also had the missing header.

@andrewcameronsims andrewcameronsims marked this pull request as ready for review November 23, 2022 07:49
@andrewcameronsims andrewcameronsims marked this pull request as draft November 23, 2022 08:05
Signed-off-by: Andrew Sims <andrew.cameron.sims@gmail.com>
@andrewcameronsims andrewcameronsims force-pushed the add_copyright_header_issue-14827 branch from a37630c to f656fa0 Compare November 23, 2022 08:14
@andrewcameronsims andrewcameronsims changed the title etcdhttp: add copyright header to health_test.go Add missing copyright headers Nov 23, 2022
@andrewcameronsims andrewcameronsims marked this pull request as ready for review November 23, 2022 08:15
@andrewcameronsims
Copy link
Contributor Author

Hello @ahrtr, hoping for a review on this PR when you have time. Thanks! 🙏

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @andrewcameronsims

@ahrtr ahrtr merged commit a47cdc3 into etcd-io:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants