-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copyright header for health_test.go #14827
Comments
This should be prevented by Code Lines 476 to 481 in 2e790d2
Would be good to follow up this issue with fixining |
Bhargav-InfraCloud
added a commit
to Bhargav-InfraCloud/etcd
that referenced
this issue
Nov 23, 2022
The shell function go_srcs_in_module will list go test files along with go src files in the specified module. This helps in identifying the copyright header misses in test files. Fixes etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud
added a commit
to Bhargav-InfraCloud/etcd
that referenced
this issue
Nov 23, 2022
Comments fixed as per goword in go test files that shell function go_srcs_in_module lists as per changes on etcd-io#14827 Helps in etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud
added a commit
to Bhargav-InfraCloud/etcd
that referenced
this issue
Nov 23, 2022
Comments fixed as per goword in go test files that shell function go_srcs_in_module lists as per changes on etcd-io#14827 Helps in etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud
added a commit
to Bhargav-InfraCloud/etcd
that referenced
this issue
Nov 23, 2022
The shell func go_srcs_in_module will now list 1. go src files 2. go test files belong to same packages 3. go test files that belong to _test packages Fixes etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Bhargav-InfraCloud
added a commit
to Bhargav-InfraCloud/etcd
that referenced
this issue
Nov 23, 2022
Comments fixed as per goword in go _test package files that shell function go_srcs_in_module lists as per changes on etcd-io#14827 Helps in etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
ahrtr
added a commit
that referenced
this issue
Nov 23, 2022
…test-files Shell func go_srcs_in_module to list go src+test files (#14827)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added?
Add copyright header for
https://github.com/etcd-io/etcd/blob/main/server/etcdserver/api/etcdhttp/health_test.go
Why is this needed?
Each file should have the copyright header
The text was updated successfully, but these errors were encountered: