Shell func go_srcs_in_module to list go src+test files (#14827) #14840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell function go_srcs_in_module will list go test files along with go src files in the specified module. This helps in identifying the copyright header misses in test files. Fixes etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Comments fixed as per goword in go test files that shell function go_srcs_in_module lists as per changes on etcd-io#14827 Helps in etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
The shell func go_srcs_in_module will now list 1. go src files 2. go test files belong to same packages 3. go test files that belong to _test packages Fixes etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Comments fixed as per goword in go _test package files that shell function go_srcs_in_module lists as per changes on etcd-io#14827 Helps in etcd-io#14827 Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
|
@serathius @ahrtr please review. Thanks! |
serathius
approved these changes
Nov 23, 2022
|
Really great work! |
ahrtr
approved these changes
Nov 23, 2022
|
Thanks! @ahrtr @serathius |
|
Really great first contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue 14671
Changes
TestGoFiles&XTestGoFilesadded in shell funcgo_srcs_in_module.goword.Summary
The shell func
go_srcs_in_modulewhich originally was listing only go src files is made to list go test files too. This is used byverify-license-headerwhich checks for copyright headers in go files. Making the func to list test files will help in identifying the go test files that miss copyright headers.Go template terminology:
1.
GoFiles- for go source files2.
TestGoFiles- for go test files which share the same package names3.
XTestGoFiles- for go test files that belong to_testpackagesAs
go_srcs_in_moduleis used by other verifications too, the comments in different tests are fixed to make itverify-gowordcompliant.Related Issues
Closes #14827