Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] etcdserver: fix corruption check when server has just been compacted #16048

Merged
merged 1 commit into from
Jun 19, 2023
Merged

[3.5] etcdserver: fix corruption check when server has just been compacted #16048

merged 1 commit into from
Jun 19, 2023

Conversation

kkkkun
Copy link
Contributor

@kkkkun kkkkun commented Jun 11, 2023

cherry-pick #14457

@kkkkun kkkkun changed the title cherry-pick #14457 to release-3.5 [3.5] etcdserver: fix corruption check when server has just been compacted Jun 11, 2023
ahrtr
ahrtr approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kkkkun

Please raise a separate PR to update the changelog item.

jmhbnz
jmhbnz approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for following up on this @kkkkun.

@kkkkun kkkkun mentioned this pull request Jun 12, 2023
Merged
@kkkkun
Copy link
Contributor Author

kkkkun commented Jun 18, 2023

@serathius @ahrtr Would you please merge this? #16051 is merged firstly.

@ahrtr ahrtr merged commit 306c60a into etcd-io:release-3.5 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkkkun @serathius @ahrtr @jmhbnz