Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 3.4 and 3.5 changelogs #16051

Merged
merged 1 commit into from
Jun 16, 2023
Merged

update 3.4 and 3.5 changelogs #16051

merged 1 commit into from
Jun 16, 2023

Conversation

kkkkun
Copy link
Contributor

@kkkkun kkkkun commented Jun 12, 2023

update #16047 and #16048 to Changelog

jmhbnz
jmhbnz reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkkkun, just a minor suggestion around wording.

CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-3.5.md Outdated Show resolved Hide resolved
@kkkkun
Copy link
Contributor Author

kkkkun commented Jun 12, 2023

Thanks @kkkkun, just a minor suggestion around wording.

Thanks. Done.

ahrtr
ahrtr reviewed Jun 12, 2023
View reviewed changes
CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-3.5.md Outdated Show resolved Hide resolved
@kkkkun
update 3.4 and 3.5 changelogs
03c9e71 
Signed-off-by: kkkkun <scuzk373x@gmail.com>
ahrtr
ahrtr approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kkkkun

@tjungblu
Copy link
Contributor

@serathius can you hit the merge button please? then I can add my lease backport changes on top of it

@serathius serathius merged commit 90cbadc into etcd-io:main Jun 16, 2023
@kkkkun kkkkun mentioned this pull request Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkkkun @tjungblu @serathius @ahrtr @jmhbnz