-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Introduce the CompactionSleepInterval flag #18514
Conversation
Hi @JalinWang. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
This pull request fixes #18481 |
/cc @ivanvc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Jalin.
Can you please squash your commits? Thanks again.
This is a backporting cherry-pick of the following commits: - add flagsline Signed-off-by: Jalin Wang <JalinWang@outlook.com> - etcdserver: rename defaultCompactionSleepInterval var (etcd-io#18495) etcdserver: rename `minimumBatchInterval` to `defaultCompactionSleepInterval` and `defaultCompactBatchLimit` to `defaultCompactionBatchLimit` Signed-off-by: Jalin Wang <JalinWang@outlook.com> (cherry picked from commit 2c53be7) - test: add CompactionSleepInterval in FakeStore's config After setting the ComparionSleepInterval, we can use time.Ticker instead of time.After to optimize the scheduleComparison(), otherwise it will fail in the 'TestStoreCompact(t)' test. Signed-off-by: guozhao <guozhao@360.cn> (cherry picked from commit fab8474) - add sleep interval (cherry picked from commit 184b0e5) Signed-off-by: Jalin Wang <JalinWang@outlook.com>
aee67cd
to
0263597
Compare
Done~~ Thanks to you and Benjamin for reviewing&approving and ArkaSaha30 for linking the issue. Sorry for the troubles caused by my first-time contribution 🙏 |
BTW, it seems I should create another PR to update the CHANGELOG in master? |
@JalinWang, there is nothing to worry about; you're doing awesome :) Yes, please open another PR in the main branch after we merge this. Thanks again. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, JalinWang, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[3.5] Introduce the CompactionSleepInterval flag
Backport according to #18485 (comment).
This is a cherry-pick of:
Just for run testing, and I'll squash it later if passed :)