Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable gosimple linter #18973

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch from 9eabd9b to 9b0415a Compare November 30, 2024 15:09
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch from 9b0415a to b11eea1 Compare November 30, 2024 15:18
@mmorel-35 mmorel-35 changed the title Bump github.com/golangci/golangci-lint to v1.62.2 and activate gosimple linter fix: enable gosimple linter Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (b038739) to head (647f162).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/defrag_command.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/main.go 0.00% <ø> (ø)
server/etcdserver/api/v3discovery/discovery.go 67.80% <100.00%> (ø)
server/etcdserver/cluster_util.go 66.30% <100.00%> (-3.41%) ⬇️
server/etcdserver/corrupt.go 89.81% <ø> (-0.03%) ⬇️
server/storage/mvcc/hash.go 97.05% <100.00%> (-0.05%) ⬇️
server/storage/wal/version.go 51.53% <100.00%> (+0.62%) ⬆️
etcdctl/ctlv3/command/defrag_command.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18973      +/-   ##
==========================================
- Coverage   68.82%   68.78%   -0.05%     
==========================================
  Files         420      420              
  Lines       35621    35615       -6     
==========================================
- Hits        24517    24498      -19     
- Misses       9683     9689       +6     
- Partials     1421     1428       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b038739...647f162. Read the comment docs.

@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch 2 times, most recently from 590f896 to 5f011ee Compare November 30, 2024 15:21
@mmorel-35 mmorel-35 marked this pull request as ready for review November 30, 2024 15:22
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch 5 times, most recently from fc207de to 38b35a6 Compare December 1, 2024 21:35
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch from 38b35a6 to 0e22ff3 Compare December 2, 2024 21:10
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch 3 times, most recently from 3c018e6 to 9e90c25 Compare December 3, 2024 06:31
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v1.62.2 branch from 9e90c25 to 647f162 Compare December 3, 2024 06:32
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the simplication.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit da807d7 into etcd-io:main Dec 4, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint@v1.62.2 branch December 4, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants