-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable gosimple linter #18973
fix: enable gosimple linter #18973
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9eabd9b
to
9b0415a
Compare
9b0415a
to
b11eea1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18973 +/- ##
==========================================
- Coverage 68.82% 68.78% -0.05%
==========================================
Files 420 420
Lines 35621 35615 -6
==========================================
- Hits 24517 24498 -19
- Misses 9683 9689 +6
- Partials 1421 1428 +7 Continue to review full report in Codecov by Sentry.
|
590f896
to
5f011ee
Compare
fc207de
to
38b35a6
Compare
38b35a6
to
0e22ff3
Compare
3c018e6
to
9e90c25
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
9e90c25
to
647f162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the simplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.