-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: golangci-lint yamllint #19013
fix: golangci-lint yamllint #19013
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19013 +/- ##
==========================================
- Coverage 68.81% 68.77% -0.05%
==========================================
Files 420 420
Lines 35623 35623
==========================================
- Hits 24515 24500 -15
- Misses 9684 9703 +19
+ Partials 1424 1420 -4 Continue to review full report in Codecov by Sentry.
|
@@ -8,7 +8,7 @@ issues: | |||
# exclude ineffassing linter for generated files for conversion | |||
- path: conversion\.go | |||
linters: [ineffassign] | |||
- text: "S1000" # TODO: Fix me | |||
- text: "S1000" # TODO: Fix me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We forgot to add the "ok-to-test" label, so it was NOT detected in previous PR #18973
Can we enforce the "ok-to-test" label before merging any PR technically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this we need to enable tide
prow plugin and delegate the merging of pr's to tide so we no longer do it manually. Usually the tide criteria is combination of approved
and lgtm
labels I think but we could probably require ok-to-test
as well.
I discussed enabling tide with @serathius in Salt Lake City KubeCon but I have not had bandwidth to plan the change yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. The immediate solution that I can think of is to fail the Approve GitHub Workflows if ok-to-test
label isn't present. Accordingly it breaks the merge-when-workflow-green
rule.
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Golangci-lint config file is not well formatted. This fixes it